512504 - OS/2 don't link against external libs that are stubs when the real function is in libc

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.1.2) Gecko/20090802 Firefox/3.5.2
Build Identifier: 

Dave stated in bug511945 c#6 that linking against (lib)dl and (lib)socket and all the math stuff (e.g. (lib)m) is not necessary as all the functions needed are provided by libc. In my tree I removed all occurrences like -lsocket -ldl and -lm and got a well running browser, even flash 7R14 worked.
We should remove these dependencies, because they make trouble in bug511945 and might make trouble in the future. Particularly since we probably do not gain anything from them. 


Reproducible: Always

Comment 1

[Walter Meinl]

Dave, since your patch attached to bug511945 isn't the real solution for that bug, I'd like to ask you to attach it here (can you attach a CVS patch? If not I can do it for you).
I'll attach a patch for the main tree and js/src.

Comment 2

[Walter Meinl]

Attachment: remove linking against socket dl and m from the build tree (except nspr)

Comment 3

[Walter Meinl]

Attachment: corrected version

forgot to sync js/src/configure.in after editing a comment in configure.in

Comment 4

[Dave Yeo]

Attachment: Remove libldl and libsocket from nsprpub/configure.in

Walter, I believe I have created this patch according to the guidelines, if not can you recreate it and tell me the correct command.

Comment 5

[Walter Meinl]

Attachment: Dave's patch against nspr configure diffed against nspr cvs HEAD

IIRC, nspr and nss patches should be attached as diff's against CVS HEAD of nspr/nss. I updated my nspr tree to HEAD applied Dave's hg patch and rediffed using cvs -d -p -u8.

Comment 6

[Peter Weilbacher]

Comment on attachment 396487 [details] [diff] [review]
corrected version

Yes, this should be OK. Although in principle, I think, one should have different patches for the main mozilla-central build stuff and stuff in js/.

Comment 7

[Peter Weilbacher]

Comment on attachment 396641 [details] [diff] [review]
Remove libldl and libsocket from nsprpub/configure.in

While I'm sure this is OK, NSPR stuff really needs to go into a separate bug (and then wtc should review it).

Comment 8

[Peter Weilbacher]

I won't have time to check this in...

Comment 9

[Peter Weilbacher]

http://hg.mozilla.org/mozilla-central/rev/582caefb4cf1